Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bare url warnings in multipart docs #1289

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Fix bare url warnings in multipart docs #1289

merged 1 commit into from
Jun 22, 2021

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Jun 22, 2021

The comments are not intended as doc comments.

Warnings
warning: this URL is not a hyperlink
   --> src/async_impl/multipart.rs:411:5
    |
411 | /// https://url.spec.whatwg.org/#fragment-percent-encode-set
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://url.spec.whatwg.org/#fragment-percent-encode-set>`
    |
    = note: `#[warn(rustdoc::bare_urls)]` on by default
    = note: bare URLs are not automatically turned into clickable links

warning: this URL is not a hyperlink
   --> src/async_impl/multipart.rs:419:5
    |
419 | /// https://url.spec.whatwg.org/#path-percent-encode-set
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://url.spec.whatwg.org/#path-percent-encode-set>`
    |
    = note: bare URLs are not automatically turned into clickable links

warning: this URL is not a hyperlink
   --> src/async_impl/multipart.rs:424:5
    |
424 | /// https://tools.ietf.org/html/rfc8187#section-3.2.1
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://tools.ietf.org/html/rfc8187#section-3.2.1>`
    |
    = note: bare URLs are not automatically turned into clickable links

@seanmonstar seanmonstar merged commit eee19c5 into seanmonstar:master Jun 22, 2021
@nickelc nickelc deleted the fix-bare-url-warnings branch June 22, 2021 14:44
pfernie added a commit to pfernie/reqwest that referenced this pull request Jun 25, 2021
* master:
  add option to disable http2 upgrade (seanmonstar#1292)
  Fix documentation of http1_title_case_headers() (seanmonstar#1294)
  CI: make a single final job that depends on all others (seanmonstar#1291)
  Fix bare url warnings in `multipart` docs (seanmonstar#1289)
  v0.11.4
  Allow overriding of DNS resolution to specified IP addresses(seanmonstar#561) (seanmonstar#1277)
  WASM: Add `try_clone` implementations to `Request` and `RequestBuilder` (seanmonstar#1286)
  Add native-tls-alpn feature (seanmonstar#1283)
Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants