fix: Form::text on wasm setting octet-stream mime type and file name. #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately JS's fetch API is somewhat limited and only supports two
options for multipart form data parts:
1) String with no file name and no mime type (which should be
interpreted as text/plain).
2) Blob with a file name ("blob" if not provided by the user) and a
mime type if provided by the user.
Until this commit, reqwest always used the latter option, so when a user
tried to add a text part with no file name, it would be sent with a mime
type of `application/octet-stream` and the filename "blob".
While we can't make the behaviour identical to the native
implementation, we can do a best-effort approach, using option (1) as
long as the user hasn't set a file name or a non plain text mime type.
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Mar 20, 2024
Bumps reqwest from 0.11.26 to 0.11.27. Release notes Sourced from reqwest's releases. v0.11.27 What's Changed Add hickory-dns feature, deprecating trust-dns. (wasm) Fix Form::text() to not set octet-stream for plain text fields. New Contributors @ashdnazg made their first contribution in seanmonstar/reqwest#2174 Full Changelog: seanmonstar/reqwest@v0.11.26...v0.11.27 Changelog Sourced from reqwest's changelog. v0.11.27 Add hickory-dns feature, deprecating trust-dns. (wasm) Fix Form::text() to not set octet-stream for plain text fields. Commits cf69fd4 v0.11.27 d0d2b47 docs: add note about sponsors/support 2fe53c5 refactor: Migrate trust-dns to hickory-dns 6904889 (wasm) fix: Form::text on wasm setting octet-stream mime type and file name. ... See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
…e name. (seanmonstar#2174) Unfortunately JS's fetch API is somewhat limited and only supports two options for multipart form data parts: 1) String with no file name and no mime type (which should be interpreted as text/plain). 2) Blob with a file name ("blob" if not provided by the user) and a mime type if provided by the user. Until this commit, reqwest always used the latter option, so when a user tried to add a text part with no file name, it would be sent with a mime type of `application/octet-stream` and the filename "blob". While we can't make the behaviour identical to the native implementation, we can do a best-effort approach, using option (1) as long as the user hasn't set a file name or a non plain text mime type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1740, Closes #2002
Unfortunately JS's fetch API is somewhat limited and only supports two
options for multipart form data parts:
interpreted as text/plain).
mime type if provided by the user.
Until this commit, reqwest always used the latter option, so when a user
tried to add a text part with no file name, it would be sent with a mime
type of
application/octet-streamand the filename "blob".While we can't make the behaviour identical to the native
implementation, we can do a best-effort approach, using option (1) as
long as the user hasn't set a file name or a non plain text mime type.