Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookie 0.12 and cookie_store 0.7 #518

Merged
merged 3 commits into from
May 6, 2019

Conversation

repi
Copy link
Contributor

@repi repi commented May 3, 2019

Fixes cookie compile error (#517) by only using ring 0.14 instead of mix of 0.13 & 0.14.

Fix seanmonstar#517 and use ring 0.14 instead of 0.13
@seanmonstar
Copy link
Owner

Thanks for the PR! Looks like cookie_store is using the brand new TryFrom traits, making this fail reqwest's minimum rust version check. Hm, while I've generally cared much less about increasing that, TryFrom has been stable for less than a month! I'm not sure which way to fall, yet....

@repi
Copy link
Contributor Author

repi commented May 3, 2019

Yeah saw that, unfortunate and tricky with bleeding edge Rust usage in a small crate that big stable dependencies like reqwest depends on. And tricky again that this upgrade was specifically required due to cookie using ring which there can only be one of. Not fully ideal.

I do think your suggestion of splitting cookie into a separate cookie-secure that has the ring dependency would be best (rwf2/cookie-rs#120). Or if cookie could use a Rust-only crate instead of ring (rwf2/cookie-rs#113). or both.

@pfernie
Copy link
Contributor

pfernie commented May 3, 2019

I have no issue dropping cookie_store back to using the try_from crate to avoid the minimum version bump. Let me know your inclination and I can cut a new release if that’s preferred.

@seanmonstar
Copy link
Owner

@pfernie if you wouldn't mind, that'd help a lot! As I said, I'm fine with minimum rust version bumps usually, it's just quite likely that many people haven't yet upgraded to 1.34, as it's under a month old. After a few months, I would think nothing of it.

@pfernie
Copy link
Contributor

pfernie commented May 4, 2019

cookie_store v0.7.0 has been published, which reverts to using try_from crate for now.

@repi repi changed the title Update cookie 0.12 and cookie_store 0.6 Update cookie 0.12 and cookie_store 0.7 May 4, 2019
@repi
Copy link
Contributor Author

repi commented May 5, 2019

Passes the checks now, merge in?

@seanmonstar seanmonstar merged commit 7956024 into seanmonstar:master May 6, 2019
@seanmonstar
Copy link
Owner

Thanks! (Sorry, I try to disconnect on weekends.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants