-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cookie 0.12 and cookie_store 0.7 #518
Update cookie 0.12 and cookie_store 0.7 #518
Conversation
Fix seanmonstar#517 and use ring 0.14 instead of 0.13
Thanks for the PR! Looks like cookie_store is using the brand new |
Yeah saw that, unfortunate and tricky with bleeding edge Rust usage in a small crate that big stable dependencies like reqwest depends on. And tricky again that this upgrade was specifically required due to I do think your suggestion of splitting |
I have no issue dropping cookie_store back to using the try_from crate to avoid the minimum version bump. Let me know your inclination and I can cut a new release if that’s preferred. |
@pfernie if you wouldn't mind, that'd help a lot! As I said, I'm fine with minimum rust version bumps usually, it's just quite likely that many people haven't yet upgraded to 1.34, as it's under a month old. After a few months, I would think nothing of it. |
cookie_store v0.7.0 has been published, which reverts to using |
Passes the checks now, merge in? |
Thanks! (Sorry, I try to disconnect on weekends.) |
Fixes cookie compile error (#517) by only using
ring
0.14 instead of mix of 0.13 & 0.14.