You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
let (https_addr, https_server) = warp::serve(routes)
.tls()
.cert_path(&cert_path)
.key_path(&cert_path) // key and cert are in same file in .pem files
.bind_with_graceful_shutdown((addr, *port), async move {
// ...
})
In the old code the builder roughly did: "give me the pkcs8 private key" nope, give me the "rsa private key" ok/nope ...
In the 3.7 code it checks that all of the entries in the pem file are keys before using the last entry.
Will post a PR to ignore non-key entries shortly and begin a conversation on the correct fix ...
The text was updated successfully, but these errors were encountered:
Summary:
Broken by:
D68332922 [rust] Update warp package 0.3.0 -> 0.3.7
In the old code the builder roughly did: "give me the pkcs8 private key" nope, give me the "rsa private key" ok/nope ...
In the 3.7 code it checks that _all_ of the entries in the pem file are keys before using the last entry.
filed an issue w/ the maintainer: seanmonstar/warp#1113 sent them a PR and this diff vends it back to us
NOTE: looks like I picked up master with this which also includes some dependency bumps but no warp code changes.
Reviewed By: neagan
Differential Revision: D68513414
fbshipit-source-id: 9667a2afa5fb9fdeb43a1f7b6b106c103d71d1d5
Summary:
Broken by:
D68332922 [rust] Update warp package 0.3.0 -> 0.3.7
In the old code the builder roughly did: "give me the pkcs8 private key" nope, give me the "rsa private key" ok/nope ...
In the 3.7 code it checks that _all_ of the entries in the pem file are keys before using the last entry.
filed an issue w/ the maintainer: seanmonstar/warp#1113 sent them a PR and this diff vends it back to us
NOTE: looks like I picked up master with this which also includes some dependency bumps but no warp code changes.
Reviewed By: neagan
Differential Revision: D68513414
fbshipit-source-id: 9667a2afa5fb9fdeb43a1f7b6b106c103d71d1d5
jdthomas
added a commit
to jdthomas/warp
that referenced
this issue
Jan 23, 2025
Version
Worked in 0.3.0 fails in 0.3.7.
Platform
N/A
Description
Usage looks roughly like:
In the old code the builder roughly did: "give me the pkcs8 private key" nope, give me the "rsa private key" ok/nope ...
In the 3.7 code it checks that all of the entries in the pem file are keys before using the last entry.
Will post a PR to ignore non-key entries shortly and begin a conversation on the correct fix ...
The text was updated successfully, but these errors were encountered: