Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch crate::never::Never with futures::never::Never #298

Merged
merged 1 commit into from
Nov 7, 2019
Merged

switch crate::never::Never with futures::never::Never #298

merged 1 commit into from
Nov 7, 2019

Conversation

jxs
Copy link
Collaborator

@jxs jxs commented Nov 5, 2019

address #297

@seanmonstar
Copy link
Owner

I'd hoped we could replace the type with ! when it stabilizes in 2037 ;_;

@seanmonstar
Copy link
Owner

Oh, just realized futures::never::Never is a type alias for std::convert::Infallible, which itself is planned to be a type alias for !.

Ok, I'm fine with this, but let's just point at std::convert::Infallible directly.

@jxs
Copy link
Collaborator Author

jxs commented Nov 7, 2019

ok, updated it!

@jxs jxs merged commit b4c0228 into seanmonstar:master Nov 7, 2019
@jxs jxs mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxs @seanmonstar