feat!: drop qmllint support as it's superseded by qmlls

seanwu1105 · Feb 10, 2023 · 01bbbaf · 01bbbaf
1 parent 0617762
commit 01bbbaf
Show file tree

Hide file tree

Showing 20 changed files with 6 additions and 1,183 deletions.
diff --git a/package.json b/package.json
@@ -218,27 +218,6 @@
     "configuration": {
       "title": "Qt for Python",
       "properties": {
-        "qtForPython.qmllint.enabled": {
-          "type": "boolean",
-          "default": true,
-          "markdownDescription": "Enable the Qt `qmllint` integration.",
-          "scope": "resource"
-        },
-        "qtForPython.qmllint.path": {
-          "type": "string",
-          "default": "",
-          "markdownDescription": "The path to Qt `qmllint` executable. Set to empty string to automatically resolve from the installed Python package. See [here](https://github.com/seanwu1105/vscode-qt-for-python#predefined-variables) for a detailed list of predefined variables.",
-          "scope": "resource"
-        },
-        "qtForPython.qmllint.options": {
-          "type": "array",
-          "items": {
-            "type": "string"
-          },
-          "default": [],
-          "markdownDescription": "The options passed to Qt `qmllint` executable. See [here](https://github.com/seanwu1105/vscode-qt-for-python#predefined-variables) for a detailed list of predefined variables.",
-          "scope": "resource"
-        },
         "qtForPython.qmlls.enabled": {
           "type": "boolean",
           "default": true,

diff --git a/python/.coveragerc b/python/.coveragerc
@@ -1,7 +1,6 @@
 [run]
 omit =
     **/test_*.py
-    scripts/qmllint.py
     scripts/qmlls.py
     scripts/rcc.py
     scripts/uic.py

diff --git a/python/scripts/qmllint.py b/python/scripts/qmllint.py
diff --git a/python/tests/assets/qml/schema.json b/python/tests/assets/qml/schema.json
diff --git a/python/tests/test_qmllint.py b/python/tests/test_qmllint.py
diff --git a/src/extension.ts b/src/extension.ts
@@ -2,7 +2,6 @@ import type { ExtensionContext, OutputChannel } from 'vscode'
 import { commands, window } from 'vscode'
 import { COMMANDS } from './commands'
 import { EXTENSION_NAMESPACE } from './constants'
-import { registerQmlLint } from './qmllint/register'
 import { registerQmlLanguageServer } from './qmlls/client'
 import type { ExecError, StdErrError } from './run'
 import type { ErrorResult, SuccessResult } from './types'
@@ -21,12 +20,6 @@ export async function activate(context: ExtensionContext) {
     onResultReceived,
   })
 
-  registerQmlLint({
-    subscriptions: context.subscriptions,
-    extensionPath: context.extensionPath,
-    onResult: onResultReceived,
-  })
-
   registerQmlLanguageServer({
     subscriptions: context.subscriptions,
     extensionPath: context.extensionPath,

diff --git a/src/qmllint/code-actions.ts b/src/qmllint/code-actions.ts