fix: compile ||

searchfe · Feb 3, 2021 · 214058b · 214058b
1 parent 4a65e6e
commit 214058b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/emitters/emitter.ts b/src/emitters/emitter.ts
@@ -369,9 +369,7 @@ export class PHPEmitter extends Emitter {
             this.writeSyntaxNode(node.rhs)
             break
         case '||':
-            this.write('isset(')
             this.writeSyntaxNode(node.lhs)
-            this.write(')')
             this.write(' ? ')
             this.writeSyntaxNode(node.lhs)
             this.write(' : ')

diff --git a/test/unit/emitters/emitter.spec.ts b/test/unit/emitters/emitter.spec.ts
@@ -354,7 +354,7 @@ describe('PHPEmitter', function () {
                 }
             })
 
-            expect(emitter.fullText()).toEqual('isset($foo) ? $foo : $bar')
+            expect(emitter.fullText()).toEqual('$foo ? $foo : $bar')
         })
 
         it('should write isset', function () {
-Original file line number
+Diff line change
@@ Expand Up / @@ -354,7 +354,7 @@ describe('PHPEmitter', function () { @@
                     }
                 })
-                expect(emitter.fullText()).toEqual('isset($foo) ? $foo : $bar')
+                expect(emitter.fullText()).toEqual('$foo ? $foo : $bar')
             })
             it('should write isset', function () {
@@ Expand Down @@