fix: binary expression in template need quote

searchfe · Nov 13, 2019 · 66b1215 · 66b1215
1 parent f899861
commit 66b1215
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/src/emitter.ts b/src/emitter.ts
@@ -1443,7 +1443,14 @@ export function emitFile(
 
     function emitTemplateSpan(node: ts.TemplateSpan) {
         writeSpace();
+        let needQuote = !ts.isIdentifier(node.expression);
+        if (needQuote) {
+            writePunctuation("(");
+        }
         emitExpression(node.expression);
+        if (needQuote) {
+            writePunctuation(")");
+        }
         emit(node.literal);
     }
 

diff --git a/test/features/template.php b/test/features/template.php
@@ -3,3 +3,6 @@
 $b = "123";
 $c = "0" . $b . "45'6'\"789\"";
 $s = "1" . $b . "2" . $b . "3" . $b . "4";
+$sa = "111";
+$i = 123;
+$sa . "_" . ($i ? "a" : "b") . "_" . ($i + 2) . "_" . ("1" . $b . "2" . $b . "3" . $b . "4");
diff --git a/test/features/template.ts b/test/features/template.ts
@@ -1,3 +1,7 @@
 const b = `123`;
 const c = `0${b}45'6'"789"`;
 const s = `1${b}2${b}3${b}4`;
+
+let sa = '111';
+let i = 123;
+sa + `_${i ? 'a' : 'b'}_${i + 2}_${`1${b}2${b}3${b}4`}`;