fix: add default initializer for unrequired parameter, close #115

searchfe · Jun 4, 2020 · 9050165 · 9050165
1 parent dfd03d7
commit 9050165
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/emitter.ts b/src/emitter.ts
@@ -742,6 +742,9 @@ export function emitFile(
         else {
             emitTypeAnnotation(node.type);
         }
+        if (node.questionToken && !node.initializer) {
+            node.initializer = ts.createIdentifier('null');
+        }
         // The comment position has to fallback to any present node within the parameterdeclaration because as it turns out, the parser can make parameter declarations with _just_ an initializer.
         emitInitializer(node.initializer, node.type ? node.type.end : node.questionToken ? node.questionToken.end : node.name ? node.name.end : node.modifiers ? node.modifiers.end : node.decorators ? node.decorators.end : node.pos, node);
     }

diff --git a/test/features/FunctionDeclaration.md b/test/features/FunctionDeclaration.md
@@ -4,7 +4,7 @@ FunctionDeclaration
 ## FunctionDeclaration
 
 ```ts
-function aaa(a: string, b: string, c: string = undefined) {
+function aaa(a: string, b?: string, c: string = undefined) {
     const d = 123;
     const e = b + 123;
     return `1${a}2${e}3${c}4${d}`;
@@ -42,7 +42,7 @@ if (b) {
 ```
 
 ```php
-function aaa($a, $b, $c = null) {
+function aaa($a, $b = null, $c = null) {
     $d = 123;
     $e = $b . 123;
     return "1" . $a . "2" . $e . "3" . $c . "4" . $d;

diff --git a/test/features/funcParamRefer.md b/test/features/funcParamRefer.md
@@ -25,7 +25,7 @@ $b = array(
     "a" => 1
 );
 $c = "123";
-function aaa($m, $n, $k, $d) {
+function aaa($m, $n, $k, $d = null) {
     array_push($m, 4);
     $n["b"] = 2;
     $k .= "4";