Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Ability To Define Custom Reporters #299

Merged
merged 3 commits into from
Aug 11, 2016

Conversation

samjonester
Copy link
Contributor

  • Adds the ability to define Standard Out reporters and File System reporters through plugin configuration.
  • Adds documentation for defining custom reporters.
  • Adds example project with cucumber test for defining custom reporters.
  • Refactors responsibilities out of larger classes.

…iguration.

- Adds `reporters` property to support list of reports.
- Adds example project and cucumber test defining custom reporters
- Adds documentation for defining custom reporters.
- Allows `STANDARD` to be used as a reporter in the list defined
  reporters.
- Defaults to the `STANDARD` reporter if none are provided.
- Splits responsibilities out of classes that were growing large and
  difficult to test. `AbstractJasmineMojo` and `SpecRunnerExecutor`.
…guration.

    - Adds `fileSystemReporters` property to support list of reports.
    - Adds file system reporter to custom reporters example project.
    - Updates documentation for defining custom reporters.
    - Allows `JUNIT_XML` to be used as a file system reporter in the list of defined reporters.
    - Defaults to the `JUNIT_XML` reporter if none are provided.
@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage increased (+3.3%) to 58.591% when pulling 911f9ec on samjonester:multiple-reporters into 3621727 on searls:master.

@dylanb
Copy link

dylanb commented Aug 11, 2016

@searls @klieber any feedback on this PR?

@klieber
Copy link
Collaborator

klieber commented Aug 11, 2016

@dylanb, thanks for the pull request! It looks good to me. I'll try to get it in a release soon.

@klieber klieber merged commit 88e4387 into searls:master Aug 11, 2016
@dylanb
Copy link

dylanb commented Aug 11, 2016

Thanks to @samjonester

@klieber
Copy link
Collaborator

klieber commented Aug 11, 2016

Yes, sorry about that. Thanks to @samjonester for the pull request. Thanks @dylanb for reminding me to look at it. :)

@dylanb
Copy link

dylanb commented Sep 12, 2016

@klieber When do you think this change will be published?

@klieber
Copy link
Collaborator

klieber commented Sep 14, 2016

klieber pushed a commit to klieber/jasmine-maven-plugin that referenced this pull request Aug 24, 2022
* Updates error message tested for when test suite fails on a syntax error

* Adds the ability to define Standard Out reporters through plugin configuration.

- Adds `reporters` property to support list of reports.
- Adds example project and cucumber test defining custom reporters
- Adds documentation for defining custom reporters.
- Allows `STANDARD` to be used as a reporter in the list defined
  reporters.
- Defaults to the `STANDARD` reporter if none are provided.
- Splits responsibilities out of classes that were growing large and
  difficult to test. `AbstractJasmineMojo` and `SpecRunnerExecutor`.

* Adds the ability to define File System reporters through plugin configuration.

    - Adds `fileSystemReporters` property to support list of reports.
    - Adds file system reporter to custom reporters example project.
    - Updates documentation for defining custom reporters.
    - Allows `JUNIT_XML` to be used as a file system reporter in the list of defined reporters.
    - Defaults to the `JUNIT_XML` reporter if none are provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants