radio options #107
Merged
radio options #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-forms canceled.
|
diogob
force-pushed
the
radio-options
branch
9 times, most recently
from
2f0080d to
9d6434d
Compare
danielweinmann
requested changes
Nov 21, 2022
diogob
force-pushed
the
radio-options
branch
from
7555c5e to
5ba07d3
Compare
danielweinmann
requested changes
Nov 23, 2022
apps/web/app/routes/examples/forms/form-with-radio-children.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/routes/examples/forms/form-with-radio-children.tsx
Outdated
Show resolved
Hide resolved
diogob
force-pushed
the
radio-options
branch
2 times, most recently
from
d07c32b to
562d482
Compare
|
@danielweinmann I think we should default the radio group wrapper to a Thoughts? |
👌🏼 |
|
@diogob, I think |
…(with the exception of being used to define Options in createForm where we add the dependency to the generic derived from schema.
…ptions as radio groups
…be parsed as strings (including enums)
…io wrapper accordingly
…troduce a wrapper for the individual radio button
…o we are closer to MDN's example code https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Radio_Role
diogob
force-pushed
the
radio-options
branch
from
b4e2d2e to
3f0b271
Compare
diogob
force-pushed
the
radio-options
branch
2 times, most recently
from
2593fd3 to
fcb6bc8
Compare
|
@danielweinmann you can take a look now, introducing unit tests will require a little more research and I'll do it in a future PR. |
danielweinmann
requested changes
Dec 1, 2022
* Apply code review suggestions Co-authored-by: Daniel Weinmann <danielweinmann@gmail.com>
danielweinmann
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add three properties to the
Formcomponent.radiotakes a list of fields to be rendered as radio button groups.radioGroupWrapperComponenttakes a tag name or a component which will wrap radio button groups.radioWrapperComponenttakes a tag name or a component which will wrap individual radio buttons.radioComponenttakes a tag name or a component which will render each radio button.They are all optional therefore no breaking change is introduced.
This should address #54
TODO
radioWrapperComponenttoradioGroupComponent.radioWrapperComponentto wrap around individual radio options.