Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio improvements take 2 #116

Merged
merged 3 commits into from
Dec 5, 2022
Merged

radio improvements take 2 #116

merged 3 commits into from
Dec 5, 2022

Conversation

diogob
Copy link
Contributor

@diogob diogob commented Dec 2, 2022

This PR is supposed to split #113 in two parts. The commits bellow do not require any change to mapChildren.

  • Pass a11y props to RadioGroup inside Field children
  • Pass correct props to Radio inside Field children
  • Add pointer cursor to labels

@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for remix-forms ready!

Name Link
🔨 Latest commit 00c8886
🔍 Latest deploy log https://app.netlify.com/sites/remix-forms/deploys/638e32c27f036100082ed014
😎 Deploy Preview https://deploy-preview-116--remix-forms.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@diogob diogob marked this pull request as ready for review December 2, 2022 15:06
@diogob diogob force-pushed the radio-improvements-take-2 branch from dc2a64d to 056846d Compare December 2, 2022 18:00
danielweinmann
danielweinmann previously approved these changes Dec 5, 2022
@diogob diogob merged commit 6bf9929 into main Dec 5, 2022
@diogob diogob deleted the radio-improvements-take-2 branch December 5, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants