Revalidate (or at least clean) server errors on input change #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-forms ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This approach LGTM 💪🏼 |
gustavoguichard
previously approved these changes
Dec 12, 2022
…other branch when errors are set on the server only. This will allow for client-side cleaning of server generated errors (though we can't really revalidate without submitting).
diogob
force-pushed
the
revalidation-after-submission
branch
from
a8a2705 to
a820575
Compare
danielweinmann
approved these changes
Dec 13, 2022
| @@ -262,9 +262,9 @@ function createForm({ | |||
|
|
|||
| const fieldErrors = (key: keyof SchemaType) => { | |||
| const message = (formErrors[key] as unknown as FieldError)?.message | |||
| return (message && [message]) || (errors && errors[key]) | |||
| return browser() ? (message && [message]) : (errors && errors[key]) | |||
There was a problem hiding this comment.
How about the case when the user sets the errors prop on the Form?
I think it will both be in the browser and have this errors[key]
There was a problem hiding this comment.
@felipefreitag, in that case, we would have set the form error in the client here. We get the error from the prop, action data or fetcher data and set it on the client.
The only reason we still return (errors && errors[key]) is for when JS is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If we get an error coming from the server action and render it as a field error, it's safe to assume that upon changing that field value we should cease to see the error.
Since an error depends on the field and its value, and changing the value turns the error to an unknown state.
This should address #111.
Note that with the current shape of this PR is that we can't really revalidate unless we resubmit the form, and doing this on behalf of the user would be reckless at best.
It seems safer to clean the error state and allow the user to resubmit to get a new validation from the server.
TODO: