Show hidden input errors as global errors #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-forms ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Should I create an example + e2e test for this? |
felipefreitag
commented
Dec 13, 2022
felipefreitag
commented
Dec 13, 2022
felipefreitag
commented
Dec 13, 2022
|
|
||
| let globalErrors = ([] as string[]) | ||
| .concat(errors?._global || [], hiddenFieldsErrors) | ||
| .filter((error) => typeof error === 'string') |
There was a problem hiding this comment.
Some types shenanigans, I accept other ideas
There was a problem hiding this comment.
what are the other cases for typeof error?
There was a problem hiding this comment.
AFAIK, undefined
There was a problem hiding this comment.
If some of the previously iterated arrays turn out to be empty, there should be some [undefined, undefined] to filter out here
felipefreitag
commented
Dec 13, 2022
diogob
force-pushed
the
show-hidden-input-errors
branch
from
80d2be4 to
7fe318a
Compare
danielweinmann
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #10
Merges hidden field errors from any source (props, mutations, client-side validation) into global errors in order to show them to the user.