Decouple from Remix to allow usage with React Router 6.4 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-forms ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danielweinmann
changed the title
gustavoguichard
approved these changes
Nov 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
In order to decouple the lib from Remix, I thought of exporting
createFormandcreateFormActioninstead ofFormandformAction.The user will have to create their own Form and formAction by calling these functions and passing everything we need from Remix, React Router 6.4, or any other framework that implements the interfaces we need.
createFormwill need to receive the following hooks:useNavigation(currently useTransition in Remix, but we'll use the React Router name),useSubmit, anduseActionData.createFormActionwill need to receive aredirectand ajsonfunction.