-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: After 1.6.0, auto-increment of oracle pk columns are no longer supported #5288
bugfix: After 1.6.0, auto-increment of oracle pk columns are no longer supported #5288
Conversation
d46a927
to
2e49978
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5288 +/- ##
=============================================
+ Coverage 48.73% 48.81% +0.08%
- Complexity 4159 4174 +15
=============================================
Files 743 743
Lines 26590 26608 +18
Branches 3321 3327 +6
=============================================
+ Hits 12958 12989 +31
+ Misses 12232 12219 -13
Partials 1400 1400
|
rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rm-datasource/src/main/java/io/seata/rm/datasource/exec/oracle/OracleInsertExecutor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix:1.6.0~1.6.1,AT模式,当insert语句不包含主键列时,无法获取到oracle的自增主键值。
Ⅱ. Does this pull request fix one issue?
fixes #5264
Ⅲ. Why don't you add test cases (unit test/integration test)?
添加下面几个单测
io.seata.rm.datasource.exec.OracleInsertExecutorTest#testGetPkValues_SinglePk
io.seata.rm.datasource.exec.OracleInsertExecutorTest#testGetPkValues_MultiPk
io.seata.rm.datasource.exec.OracleInsertExecutorTest#testContainsAnyPK
Ⅳ. Describe how to verify it
集成测试验证了下面几种情况
Ⅴ. Special notes for reviews