Driver refactoring and cleanup, part 2 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://kubernetes-csi.github.io/docs/volume-expansion.html CSI Resizer should be always run even if not implemented. Also it should run only against controller. Volume resize on node rpc call is handled by kubelet. For now the only job for controller's volume resize is to make it two step and propagate changes to node.
…ttacher (it do nothing in reality)
* Separate NodeServer and ControllerServer * Allow leader election for sidecars and replica count fot controller component * Liveness probes * Allow disabling attacher, cause this functionality is not used in reality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring, part 2
It seems that running umount on mount point does not close weed mount process or trigger any event for this. At least it works this way on my linux box with latest code. i.e. umount is issued on mount point, mount point becomes free, but weed process continues to work and only SIGTERM tells this process to end.