Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition Attention mechanism #1

Closed
helpmefindaname opened this issue Mar 3, 2020 · 1 comment
Closed

Definition Attention mechanism #1

helpmefindaname opened this issue Mar 3, 2020 · 1 comment

Comments

@helpmefindaname
Copy link

helpmefindaname commented Mar 3, 2020

Referring to the explanation of the attention mechanism in Neural Networks for NLP slide 41

The phrase "the attention mechanism is defined as" suggests that this is the one and only definition of attention, however there are many attention mechanisms. The effect from some is evaluated here.
I'd suggesting rephrasing it to "additive attention is defined as" as that's the commonly used name for the type of attention on that slide, or to describe the mechanism more general by declaring
and noting that one example is

@sebastian-hofstaetter
Copy link
Owner

Hi,
Thank you very much for the comment - i fixed the slides (I'll update them here once the lecture took place, because i'll move a couple of things around)

Don't forget to mention this at the exercise interview for bonus points :) and keep the suggestions coming!

Best,
Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants