Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset-hash depends on node-xxhash that is not used by default and is not maintained anymore #1

Closed
sormy opened this issue Feb 26, 2019 · 2 comments

Comments

@sormy
Copy link

sormy commented Feb 26, 2019

Hello.

asset-hash depends on node-xxhash that is not used by default and is not maintained anymore.
See this PR as an example: mscdex/node-xxhash#25

  1. I propose to move "xxhash" into "optionalDependencies", conditionally check if it is loaded from "asset-hash" and use it if available and throw an exception if xxhash hashing method is used.

  2. Another option is to switch to xxhashjs that is the same I guess but pure JS.

  3. Last option is to support both xxhash and xxhashjs and use one of them dependending on what is installed, also put both of them to peerDependencies.

This change will require major version bump I guess but I would like to update just minor to not break compatiblity with postcss-smart-asset. Another good option is to bump major for both (since you own both).

Would you be open for PR and what solution would you prefer?

@swernerx
Copy link
Member

Hi! thanks for reporting. I actually never had this issue nor none of my colleagues (Mac, Windows + Gitlab CI). I figure it makes sense to move it to optional dependencies and checking the availability. Please create the PR for this. Thanks a lot.

@swernerx
Copy link
Member

Fixed with v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants