You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
asset-hash depends on node-xxhash that is not used by default and is not maintained anymore.
See this PR as an example: mscdex/node-xxhash#25
I propose to move "xxhash" into "optionalDependencies", conditionally check if it is loaded from "asset-hash" and use it if available and throw an exception if xxhash hashing method is used.
Another option is to switch to xxhashjs that is the same I guess but pure JS.
Last option is to support both xxhash and xxhashjs and use one of them dependending on what is installed, also put both of them to peerDependencies.
This change will require major version bump I guess but I would like to update just minor to not break compatiblity with postcss-smart-asset. Another good option is to bump major for both (since you own both).
Would you be open for PR and what solution would you prefer?
The text was updated successfully, but these errors were encountered:
Hi! thanks for reporting. I actually never had this issue nor none of my colleagues (Mac, Windows + Gitlab CI). I figure it makes sense to move it to optional dependencies and checking the availability. Please create the PR for this. Thanks a lot.
Hello.
asset-hash depends on node-xxhash that is not used by default and is not maintained anymore.
See this PR as an example: mscdex/node-xxhash#25
I propose to move "xxhash" into "optionalDependencies", conditionally check if it is loaded from "asset-hash" and use it if available and throw an exception if xxhash hashing method is used.
Another option is to switch to xxhashjs that is the same I guess but pure JS.
Last option is to support both xxhash and xxhashjs and use one of them dependending on what is installed, also put both of them to peerDependencies.
This change will require major version bump I guess but I would like to update just minor to not break compatiblity with postcss-smart-asset. Another good option is to bump major for both (since you own both).
Would you be open for PR and what solution would you prefer?
The text was updated successfully, but these errors were encountered: