New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make xxhash optional #2

Merged

swernerx merged 1 commit into sebastian-software:master from sormy:master

Feb 27, 2019

sormy commented Feb 26, 2019

Make xxhash optional

as discussed here: #1

Changes:

moved xxhash to optionalDependencies
replaced static import with require() and try/catch wrapper
throw error if requested xxhash32/64 hash but xxhash is not available

Tests are passing


          Make xxhash optional

4c90bc6

swernerx merged commit 464676b into sebastian-software:master

Member

swernerx commented Feb 27, 2019

Thanks!

Member

swernerx commented Feb 27, 2019

I decided to go with a minor release as this was not even used by default.

Member

swernerx commented Feb 27, 2019

Published as v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet