Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 4.0.1 breaks backward compatibility #85

Closed
acasademont opened this issue Jun 15, 2020 · 3 comments
Closed

Version 4.0.1 breaks backward compatibility #85

acasademont opened this issue Jun 15, 2020 · 3 comments
Assignees
@sebastianbergmann
Labels
bug

Comments

@acasademont
Copy link

Seems like a typehint was introduced in this patch release (https://github.com/sebastianbergmann/comparator/blob/4.0.1/src/ObjectComparator.php#L42), which makes it incompatible with prophecy at the moment. Should this change be reverted?
@acasademont acasademont mentioned this issue Jun 15, 2020
Closed
@sebastianbergmann sebastianbergmann changed the title BC-break in 4.0.1? Version 4.0.1 breaks backward compatibility Jun 15, 2020
@sebastianbergmann
Copy link
Owner

sebastianbergmann commented Jun 15, 2020 •
edited
Loading 

$ roave-backward-compatibility-check --from=4.0.0 --to=4.0.1
Comparing from b8f4faa924ca9497619bd75a15be151aa2c33093 to 1de7b33e1d1fa4a58cb29b295c6e3349d73a6c4e...
Loading composer repositories with package information
Updating dependencies
Package operations: 3 installs, 0 updates, 0 removals
  - Installing sebastian/recursion-context (4.0.1): Loading from cache
  - Installing sebastian/exporter (4.0.1): Loading from cache
  - Installing sebastian/diff (4.0.1): Loading from cache
Writing lock file
Loading composer repositories with package information
Updating dependencies
Package operations: 3 installs, 0 updates, 0 removals
  - Installing sebastian/recursion-context (4.0.1): Loading from cache
  - Installing sebastian/exporter (4.0.1): Loading from cache
  - Installing sebastian/diff (4.0.1): Loading from cache
Writing lock file
[BC] CHANGED: The return type of SebastianBergmann\Comparator\TypeComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\TypeComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\SplObjectStorageComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\SplObjectStorageComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ScalarComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ScalarComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ResourceComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ResourceComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ObjectComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ObjectComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\NumericComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\NumericComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ObjectComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ObjectComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Factory#register() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Factory#register() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Factory#unregister() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Factory#reset() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ObjectComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ObjectComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\DoubleComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\DoubleComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\DateTimeComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\DateTimeComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\DOMNodeComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\DOMNodeComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ArrayComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\ArrayComparator#assertEquals() changed from no type to void
[BC] CHANGED: The return type of SebastianBergmann\Comparator\Comparator#setFactory() changed from no type to void
42 backwards-incompatible changes detected

@sebastianbergmann sebastianbergmann self-assigned this Jun 15, 2020
@sebastianbergmann
Copy link
Owner 

$ roave-backward-compatibility-check --from=4.0.0 --to=4.0.2 
Comparing from b8f4faa924ca9497619bd75a15be151aa2c33093 to cd10b8b3a0cc068cd9bd7a4958d02efc4ee418c7...
Loading composer repositories with package information
Updating dependencies
Package operations: 3 installs, 0 updates, 0 removals
  - Installing sebastian/recursion-context (4.0.1): Loading from cache
  - Installing sebastian/exporter (4.0.1): Loading from cache
  - Installing sebastian/diff (4.0.1): Loading from cache
Writing lock file
Loading composer repositories with package information
Updating dependencies
Package operations: 3 installs, 0 updates, 0 removals
  - Installing sebastian/recursion-context (4.0.1): Loading from cache
  - Installing sebastian/exporter (4.0.1): Loading from cache
  - Installing sebastian/diff (4.0.1): Loading from cache
Writing lock file
No backwards-incompatible changes detected

@acasademont
Copy link
Author

thank you @sebastianbergmann , that was fast.

b1rdex pushed a commit to b1rdex/comparator that referenced this issue Jul 10, 2020
@sebastianbergmann @b1rdex
Closes sebastianbergmann#85
be65669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @acasademont