Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "ignore case" in DOMNodeComparator #53

Conversation

daltones
Copy link
Contributor

The logic of $ignoreCase was inverted by mistake in DOMNodeComparator.

This made PHPUnit's assertXml*EqualsXml*() case-insensitive by default.

@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage     79.14%   79.14%           
  Complexity      122      122           
=========================================
  Files            15       15           
  Lines           326      326           
=========================================
  Hits            258      258           
  Misses           68       68
Impacted Files Coverage Δ Complexity Δ
src/DOMNodeComparator.php 58.33% <0%> (ø) 10 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ca1ea...2bff546. Read the comment docs.

@daltones daltones force-pushed the fix/dom-node-comparator-ignore-case branch from 7e02c74 to 2bff546 Compare May 15, 2018 16:44
@sebastianbergmann sebastianbergmann merged commit feeec2d into sebastianbergmann:master May 23, 2018
@daltones
Copy link
Contributor Author

Hi @sebastianbergmann, thanks for merging it!

Can I count on a release with this fix soon?

@Ovsyanka
Copy link
Contributor

@daltones I think you know It but in case you don't, there is a simple workaround about this and you could use it untill the release will be done.

$this->assertEquals($expectedDom, $xmlDom, "", 0.0, 10, true, true);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants