Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 compatibility #89

Merged
merged 1 commit into from
Sep 30, 2020
Merged

PHP8 compatibility #89

merged 1 commit into from
Sep 30, 2020

Conversation

mbeccati
Copy link
Contributor

What was previously silenced, now becomes: ValueError: DOMDocument::loadXML(): Argument #1 ($source) must not be empty

E.g.

/.../tests/end-to-end/regression/GitHub/4407.phpt
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 PHPUnit 9.4-g6099c5e by Sebastian Bergmann and contributors.
 
-F                                                                   1 / 1 (100%)
+E                                                                   1 / 1 (100%)
 
 Time: 00:00.027, Memory: 6.00 MB
 
-There was 1 failure:
+There was 1 error:
 
 1) Issue4407Test::testOne
-Failed asserting that two DOM documents are equal.
---- Expected
-+++ Actual
-@@ @@
- <?xml version="1.0"?>
--<root>
--  <child>text</child>
--</root>
+ValueError: DOMDocument::loadXML(): Argument #1 ($source) must not be empty
 
-%sIssue4407Test.php:%d
+/.../tests/end-to-end/regression/GitHub/4407/Issue4407Test.php:18
 
-FAILURES!
-Tests: 1, Assertions: 1, Failures: 1.
+ERRORS!
+Tests: 1, Assertions: 1, Errors: 1.

/.../tests/end-to-end/regression/GitHub/4407.phpt:14
/.../src/Framework/TestSuite.php:669
/.../src/Framework/TestSuite.php:669
/.../src/TextUI/TestRunner.php:673
/.../src/TextUI/Command.php:148
/.../src/TextUI/Command.php:101

What was previously silenced, now becomes:

ValueError: DOMDocument::loadXML(): Argument #1 ($source) must not be empty
@sebastianbergmann sebastianbergmann merged commit e376d38 into sebastianbergmann:master Sep 30, 2020
@sebastianbergmann
Copy link
Owner

Thanks!

@mbeccati mbeccati deleted the patch-1 branch September 30, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants