Do not try to process abstract methods

sebastianbergmann · Aug 31, 2023 · 4ff9a18 · 4ff9a18
1 parent 53bca56
commit 4ff9a18
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/src/Visitor/ComplexityCalculatingVisitor.php b/src/Visitor/ComplexityCalculatingVisitor.php
@@ -46,6 +46,10 @@ public function enterNode(Node $node): ?int
                 return null;
             }
 
+            if ($node->isAbstract()) {
+                return null;
+            }
+
             $name = $this->classMethodName($node);
         } else {
             $name = $this->functionName($node);

diff --git a/tests/_fixture/ExampleClass.php b/tests/_fixture/ExampleClass.php
@@ -9,7 +9,7 @@
  */
 namespace SebastianBergmann\Complexity\TestFixture;
 
-final class ExampleClass
+abstract class ExampleClass
 {
     public function method(): void
     {
@@ -43,4 +43,6 @@ public function method(): void
         do {
         } while (false);
     }
+
+    abstract public function abstractMethod(): void;
 }
diff --git a/tests/unit/ComplexityCalculatingVisitorTest.php b/tests/unit/ComplexityCalculatingVisitorTest.php
@@ -77,9 +77,9 @@ public function numberOfNodesVisited(): int
         $this->assertSame(14, $complexityCalculatingVisitor->result()->cyclomaticComplexity());
 
         if ($shortCircuitTraversal) {
-            $this->assertSame(9, $shortCircuitVisitor->numberOfNodesVisited());
+            $this->assertSame(12, $shortCircuitVisitor->numberOfNodesVisited());
         } else {
-            $this->assertSame(70, $shortCircuitVisitor->numberOfNodesVisited());
+            $this->assertSame(73, $shortCircuitVisitor->numberOfNodesVisited());
         }
     }