Respect coverage data's own filter when merging another source #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please open a ticket with PHPUnit on the issue that the whitelist information is not passed along to the child process. Thanks! |
|
As mentioned earlier, this should be taken care of in PHPUnit (see sebastianbergmann/phpunit#1681). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case for this is that tests that are run with process isolation don't get the whitelist information passed through to the code coverage collector, so when that coverage information is merged back in to the master process, non-whitelisted files are often added.
I guess that might be something you want to fix upstream, but I imagine that's a bit more of a difficult task, so thought I'd try my luck here first :)