This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 191
[RFR] Add a regexps-exclude option #100
Merged
sebastianbergmann
merged 1 commit into
sebastianbergmann:master
from
jpetitcolas:paths_exclude
Jan 24, 2017
Merged
[RFR] Add a regexps-exclude option #100
sebastianbergmann
merged 1 commit into
sebastianbergmann:master
from
jpetitcolas:paths_exclude
Jan 24, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
2 similar comments
👍 |
👍 |
👍 |
@sebastianbergmann Any news for this one? :) |
👍 |
7 similar comments
👍 |
👍 |
👍 |
👍 |
👍 |
👍 |
👍 |
👍 |
1 similar comment
👍 |
: +1 : |
👍 |
1 similar comment
👍 |
Thank you for your contribution. Sorry that it took so long to merge your pull request. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--regexps-exclude
option to counter a limitation with other options.The
--names-exclude
option refers only to base name, which forbids to exclude a given path. For instance, if we want to excludeweb/app_*.php
it will not work. We have to excludeapp_*.php
through the--names-exclude
. But it will also excludesrc/app_test.php
for instance.The
--regexps-exclude
allows to specify a regexp which will then be inserted into thenotPath
method of the finder (a PR on finder-facade has been created). This way, we can exclude previous patterns with a command line such:phpcpd.phar --regexps-exclude '~web/app_.*\.php~' myProject
This PR can probably helps to fix some issues with the
--exclude
option, and should be an answer to #84.