Closes #4312

sebastianbergmann · Jun 22, 2020 · 34c18ba · 34c18ba
1 parent 809b4bf
commit 34c18ba
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/ChangeLog-8.5.md b/ChangeLog-8.5.md
@@ -2,6 +2,12 @@
 
 All notable changes of the PHPUnit 8.5 release series are documented in this file using the [Keep a CHANGELOG](https://keepachangelog.com/) principles.
 
+## [8.5.8] - 2020-06-22
+
+### Fixed
+
+* [#4312](https://github.com/sebastianbergmann/phpunit/issues/4312): Fix for [#4299](https://github.com/sebastianbergmann/phpunit/issues/4299) breaks backward compatibility
+
 ## [8.5.7] - 2020-06-21
 
 ### Fixed
@@ -71,6 +77,7 @@ All notable changes of the PHPUnit 8.5 release series are documented in this fil
 * [#3967](https://github.com/sebastianbergmann/phpunit/issues/3967): Cannot double interface that extends interface that extends `\Throwable`
 * [#3968](https://github.com/sebastianbergmann/phpunit/pull/3968): Test class run in a separate PHP process are passing when `exit` called inside
 
+[8.5.8]: https://github.com/sebastianbergmann/phpunit/compare/8.5.7...8.5.8
 [8.5.7]: https://github.com/sebastianbergmann/phpunit/compare/8.5.6...8.5.7
 [8.5.6]: https://github.com/sebastianbergmann/phpunit/compare/8.5.5...8.5.6
 [8.5.5]: https://github.com/sebastianbergmann/phpunit/compare/8.5.4...8.5.5

diff --git a/src/Runner/Version.php b/src/Runner/Version.php
@@ -33,7 +33,7 @@ public static function id(): string
         }
 
         if (self::$version === '') {
-            self::$version = (new VersionId('8.5.7', \dirname(__DIR__, 2)))->getVersion();
+            self::$version = (new VersionId('8.5.8', \dirname(__DIR__, 2)))->getVersion();
         }
 
         return self::$version;

diff --git a/src/TextUI/TestRunner.php b/src/TextUI/TestRunner.php
@@ -745,10 +745,6 @@ public function doRun(Test $suite, array $arguments = [], array $warnings = [],
         }
 
         if ($exit) {
-            if (\count($result) === 0) {
-                exit(self::FAILURE_EXIT);
-            }
-
             if ($result->wasSuccessfulIgnoringWarnings()) {
                 if ($arguments['failOnRisky'] && !$result->allHarmless()) {
                     exit(self::FAILURE_EXIT);