Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPT tests treat line endings inconsistently #1447

Closed
vclayton opened this issue Sep 26, 2014 · 0 comments
Closed

PHPT tests treat line endings inconsistently #1447

vclayton opened this issue Sep 26, 2014 · 0 comments

Comments

@vclayton
Copy link

Similar to #1115, PHPT tests can fail if the line endings of the EXPECT/EXPECTF section don't match the line endings in the test output. The behavior is also inconsistent with run-tests.php and PEAR_RunTest.

In run-tests.php, the all output is run through preg_replace("/\r\n/", "\n", trim($out));
The expected output is processed the same way, for both EXPECT and EXPECTF sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant