Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxDepth param of assertions is not used ? #3180

Closed
keradus opened this issue Jun 22, 2018 · 2 comments
Closed

maxDepth param of assertions is not used ? #3180

keradus opened this issue Jun 22, 2018 · 2 comments

Comments

@keradus
Copy link
Contributor

keradus commented Jun 22, 2018

What is this param? I can't find it being used anyhow
it's passed ultimately to Constraint\IsEqual::maxDepth, but it is not used as well.

i believe it's a leftover and shall be cleaned up

@stale
Copy link

stale bot commented Aug 21, 2018

This issue has been automatically marked as stale because it has not had activity within the last 60 days. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@localheinz
Copy link
Collaborator

@keradus

I agree, and I think it should be removed. Probably good for PHPUnit 8, as removing the $maxDepth parameter from constructor and other method signatures constitutes BC-issues, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants