Fix: Remove unused field $maxDepth from IsEqual constraint

[localheinz]

This PR

• removes an unused field $maxDepth from the IsEqual constraint

Related #3180.

💁‍♂️ $maxDepth still needs to be removed from a lot of other places, which partially constitute BC issues. Happy to work on it, if there are no objections!

[localheinz]

Field is assigned a value, but never used.

Removal of $maxDepth from constructor indicates a BC issue, and should probably be targeted at PHPUnit 8.0, then.

[sebastianbergmann]

I would like to understand when $maxDepth stopped being used. I do not recall a (conscious) decision to remove this functionality.

[codecov-io]

Codecov Report

Merging #3335 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3335      +/-   ##
============================================
- Coverage     82.61%   82.61%   -0.01%     
  Complexity     3533     3533              
============================================
  Files           143      143              
  Lines          9331     9330       -1     
============================================
- Hits           7709     7708       -1     
  Misses         1622     1622

Impacted Files	Coverage Δ	Complexity Δ
src/Framework/Constraint/IsEqual.php	100% <ø> (ø)	9 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5304d...11e65ce. Read the comment docs.

[localheinz]

@sebastianbergmann

I’ll have a look after breakfast!

[localheinz]

@sebastianbergmann

I might be wrong, but I think it is d38ea8f.

To find it, I ran

$ git log -S maxDepth --source --all

Does that make sense?

[sebastianbergmann]

Thanks.

It appears that this functionality has not worked for quite some time. Apparently nobody is missing it, I certainly don't miss it, so lets go ahead and remove its remnants.

However, I would like to do this atomically for all occurrences of $maxDepth in time for PHPUnit 8.

[localheinz]

@sebastianbergmann

Do you want to hold off with this until work has started on PHPUnit 8, then? Just to make sure I understand correctly.

[sebastianbergmann]

Yes. This will be done in master after PHPUnit 7.5 has been released.

[OskarStark]

Yes. This will be done in master after PHPUnit 7.5 has been released.

But it will be deprecated first, right?