-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate optional parameters of assertEquals() and assertNotEquals() #3341
Milestone
Comments
This was referenced Oct 11, 2018
sebastianbergmann
added a commit
that referenced
this issue
Oct 11, 2018
Anyone looking for upgrade path: https://github.com/rectorphp/rector/pull/825/files#diff-de1172102c1d09f6d2910b0571e5f546 |
stronk7
added a commit
to stronk7/moodle
that referenced
this issue
Sep 20, 2020
The optional parameters of assertEquals() and assertNotEquals() are deprecated in PHPUnit 8 (to be removed in PHPUnit 9): - delta => use assertEqualsWithDelta() - canonicalize => use assertEqualsCanonicalizing() - ignoreCase => use assertEqualsIgnoringCase - maxDepth => removed without replacement. More info @ sebastianbergmann/phpunit#3341 Initial search done with: ag 'assert(Not)?Equals\(.*,.*,' --php Then, running tests and fixing remaining cases.
stronk7
added a commit
to stronk7/moodle
that referenced
this issue
Oct 21, 2020
The optional parameters of assertEquals() and assertNotEquals() are deprecated in PHPUnit 8 (to be removed in PHPUnit 9): - delta => use assertEqualsWithDelta() - canonicalize => use assertEqualsCanonicalizing() - ignoreCase => use assertEqualsIgnoringCase - maxDepth => removed without replacement. More info @ sebastianbergmann/phpunit#3341 Initial search done with: ag 'assert(Not)?Equals\(.*,.*,' --php Then, running tests and fixing remaining cases.
stronk7
added a commit
to stronk7/moodle
that referenced
this issue
Oct 21, 2020
The optional parameters of assertEquals() and assertNotEquals() are deprecated in PHPUnit 8 (to be removed in PHPUnit 9): - delta => use assertEqualsWithDelta() - canonicalize => use assertEqualsCanonicalizing() - ignoreCase => use assertEqualsIgnoringCase - maxDepth => removed without replacement. More info @ sebastianbergmann/phpunit#3341 Initial search done with: ag 'assert(Not)?Equals\(.*,.*,' --php Then, running tests and fixing remaining cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These optional parameters of
assertEquals()
andassertNotEquals()
should be deprecated:$delta
(useassertEqualsWithDelta()
orassertNotEqualsWithDelta()
from Specializations of assertEquals() and assertNotEquals() #3340 instead)$maxDepth
(respective functionality was removed)$canonicalize
(useassertEqualsCanonicalizing()
orassertNotEqualsCanonicalizing()
from Specializations of assertEquals() and assertNotEquals() #3340 instead)$ignoreCase
(useassertEqualsIgnoringCase()
orassertNotEqualsIgnoringCase()
from Specializations of assertEquals() and assertNotEquals() #3340 instead)The text was updated successfully, but these errors were encountered: