Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expectExceptionMessageRegExp() #3957

Closed
sebastianbergmann opened this issue Nov 25, 2019 · 0 comments
Closed

Remove expectExceptionMessageRegExp() #3957

sebastianbergmann opened this issue Nov 25, 2019 · 0 comments
Assignees
@sebastianbergmann
Labels
type/backward-compatibility Something will be/is intentionally broken
Milestone
PHPUnit 9.0

Comments

@sebastianbergmann
Copy link
Owner

expectExceptionMessageMatches() should be used instead.
@sebastianbergmann sebastianbergmann added the type/backward-compatibility Something will be/is intentionally broken label Nov 25, 2019
@sebastianbergmann sebastianbergmann added this to the PHPUnit 9.0 milestone Nov 25, 2019
@sebastianbergmann sebastianbergmann self-assigned this Nov 25, 2019
jrfnl added a commit to jrfnl/phpunit-documentation-english that referenced this issue Feb 20, 2020
@jrfnl
PHPUnit 9.0: Replace references to expectExceptionMessageRegExp() w…
fc8b462 
…ith `expectExceptionMessageMatches()`

Based on the changelog of PHPUnit 9.0, the `expectExceptionMessageRegExp()` method has been removed and `expectExceptionMessageMatches()` should be used instead.

Refs:
* https://github.com/sebastianbergmann/phpunit/blob/9.0.1/ChangeLog-9.0.md
* sebastianbergmann/phpunit#3957
@jrfnl jrfnl mentioned this issue Feb 20, 2020
Merged
sebastianbergmann pushed a commit to sebastianbergmann/phpunit-documentation-english that referenced this issue Feb 20, 2020
@jrfnl @sebastianbergmann
PHPUnit 9.0: Replace references to expectExceptionMessageRegExp() w…
3877334 
…ith `expectExceptionMessageMatches()`

Based on the changelog of PHPUnit 9.0, the `expectExceptionMessageRegExp()` method has been removed and `expectExceptionMessageMatches()` should be used instead.

Refs:
* https://github.com/sebastianbergmann/phpunit/blob/9.0.1/ChangeLog-9.0.md
* sebastianbergmann/phpunit#3957
@morozov morozov mentioned this issue Mar 17, 2020
Merged
4 tasks
williamdes added a commit to williamdes/mariadb-mysql-kbs that referenced this issue Apr 1, 2020
@williamdes
fix: phpunit test must use expectExceptionMessageMatches intead of ex…
239fa7f 
…pectExceptionMessageRegExp

Ref: sebastianbergmann/phpunit#3957
@t0mmy742 t0mmy742 mentioned this issue Apr 11, 2020
Closed
stronk7 added a commit to stronk7/moodle that referenced this issue Sep 20, 2020
@stronk7
MDL-67673 phpunit: Remove expectedException annotations
63aa1c7 
While this is not strictly required, because removal will
happen in PHPUnit 9.0, we are already getting rid of all
uses in core.

From release notes:https://phpunit.de/announcements/phpunit-8.html

The annotations `@expectedException`, `@expectedExceptionCode`,
`@expectedExceptionMessage`, and `@expectedExceptionMessageRegExp`
are now deprecated.
Using these annotations will trigger a deprecation warning
in PHPUnit 8 and in PHPUnit 9 these annotations will be removed.

Also, all uses of expectExceptionMessageRegExp() has been moved
to expectExceptionMessageMatches(). See sebastianbergmann/phpunit#3957

TODO: Various weirdness found while doing the changes with these tests:
- vendor/bin/phpunit lib/tests/exporter_test.php (created MDL-69700)
- vendor/bin/phpunit competency/tests/external_test.php (same issue than prev one)
- vendor/bin/phpunit question/engine/tests/questionengine_test.php (created MDL-69624)
- vendor/bin/phpunit lib/tests/event_test.php (created MDL-69688)
stronk7 added a commit to stronk7/moodle that referenced this issue Oct 21, 2020
@stronk7
MDL-67673 phpunit: Remove expectedException annotations
ddf72dd 
While this is not strictly required, because removal will
happen in PHPUnit 9.0, we are already getting rid of all
uses in core.

From release notes:https://phpunit.de/announcements/phpunit-8.html

The annotations `@expectedException`, `@expectedExceptionCode`,
`@expectedExceptionMessage`, and `@expectedExceptionMessageRegExp`
are now deprecated.
Using these annotations will trigger a deprecation warning
in PHPUnit 8 and in PHPUnit 9 these annotations will be removed.

Also, all uses of expectExceptionMessageRegExp() has been moved
to expectExceptionMessageMatches(). See sebastianbergmann/phpunit#3957

TODO: Various weirdness found while doing the changes with these tests:
- vendor/bin/phpunit lib/tests/exporter_test.php (created MDL-69700)
- vendor/bin/phpunit competency/tests/external_test.php (same issue than prev one)
- vendor/bin/phpunit question/engine/tests/questionengine_test.php (created MDL-69624)
- vendor/bin/phpunit lib/tests/event_test.php (created MDL-69688)
stronk7 added a commit to stronk7/moodle that referenced this issue Oct 21, 2020
@stronk7
MDL-67673 phpunit: Remove expectedException annotations
d95c378 
While this is not strictly required, because removal will
happen in PHPUnit 9.0, we are already getting rid of all
uses in core.

From release notes:https://phpunit.de/announcements/phpunit-8.html

The annotations `@expectedException`, `@expectedExceptionCode`,
`@expectedExceptionMessage`, and `@expectedExceptionMessageRegExp`
are now deprecated.
Using these annotations will trigger a deprecation warning
in PHPUnit 8 and in PHPUnit 9 these annotations will be removed.

Also, all uses of expectExceptionMessageRegExp() has been moved
to expectExceptionMessageMatches(). See sebastianbergmann/phpunit#3957

TODO: Various weirdness found while doing the changes with these tests:
- vendor/bin/phpunit lib/tests/exporter_test.php (created MDL-69700)
- vendor/bin/phpunit competency/tests/external_test.php (same issue than prev one)
- vendor/bin/phpunit question/engine/tests/questionengine_test.php (created MDL-69624)
- vendor/bin/phpunit lib/tests/event_test.php (created MDL-69688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
type/backward-compatibility Something will be/is intentionally broken
Projects
None yet
Milestone
PHPUnit 9.0
Development

No branches or pull requests
1 participant
@sebastianbergmann