Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for assertFileEqualsCanonicalizing() #4049

Closed
sebastianbergmann opened this issue Feb 12, 2020 · 1 comment
Closed

Tests for assertFileEqualsCanonicalizing() #4049

sebastianbergmann opened this issue Feb 12, 2020 · 1 comment
Labels
feature/assertion Issues related to assertions and expectations good first issue Opportunities for people to contribute to PHPUnit for the first time type/tests Tests! Yes, PHPUnit, too, needs tests.

Comments

@sebastianbergmann
Copy link
Owner

No description provided.

@sebastianbergmann sebastianbergmann added type/tests Tests! Yes, PHPUnit, too, needs tests. good first issue Opportunities for people to contribute to PHPUnit for the first time feature/assertion Issues related to assertions and expectations labels Feb 12, 2020
pwsdotru added a commit to pwsdotru/phpunit that referenced this issue May 3, 2020
@pwsdotru
sebastianbergmann#4049 Add tests for assertFileEqualsCanonicalizing
b86d7d2
@pwsdotru pwsdotru mentioned this issue May 3, 2020
Closed
pwsdotru added a commit to pwsdotru/phpunit that referenced this issue May 3, 2020
@pwsdotru
sebastianbergmann#4049 Fix tests for assertFileEqualsCanonicalizing
38a3a50
pwsdotru added a commit to pwsdotru/phpunit that referenced this issue May 3, 2020
@pwsdotru
sebastianbergmann#4049 Skip assert for canonicalizing compare assertF…
6e5c7fc 
…ileEqualsCanonicalizing
@pwsdotru
Copy link
Contributor

pwsdotru commented May 3, 2020

For now assertFileEqualsCanonicalizing work incorrect. This assert just compare two string with simple equals (===) and not use param $canonical in comparator.

@pwsdotru pwsdotru mentioned this issue May 4, 2020
Open
sebastianbergmann pushed a commit that referenced this issue Jan 13, 2024
@pwsdotru @sebastianbergmann
#4049 Add tests for assertFileEqualsCanonicalizing
df5a404
sebastianbergmann pushed a commit that referenced this issue Jan 13, 2024
@pwsdotru @sebastianbergmann
#4049 Fix tests for assertFileEqualsCanonicalizing
79a8d46
sebastianbergmann pushed a commit that referenced this issue Jan 13, 2024
@pwsdotru @sebastianbergmann
#4049 Skip assert for canonicalizing compare assertFileEqualsCanonica…
b63fb74 
…lizing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/assertion Issues related to assertions and expectations good first issue Opportunities for people to contribute to PHPUnit for the first time type/tests Tests! Yes, PHPUnit, too, needs tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @pwsdotru