Deprecate InvocationMocker::willReturnOnConsecutiveCalls()

[sebastianbergmann]

To reduce complexity inside PHPUnit's test double functionality, InvocationMocker::willReturnOnConsecutiveCalls() will be deprecated and then removed:

• soft deprecation in PHPUnit 10.3 (add @deprecated annotation to the method declaration)
• deprecation in PHPUnit 11 (using the method will trigger a deprecation)
• removal in PHPUnit 12

[TechhDan]

Hi! If anyone is looking for a replacement for this method this one has helped me out.

$userCallCount = 0;
$this->user->expects($this->exactly(2))
    ->method('__get')
    ->willReturnCallback(function ($name) use (&$userCallCount) {
        $userCallCount++;
        switch ($userCallCount) {
            case 1:
                return 1;
            case 2:
                return 2;
        }
    });

[sebastianbergmann]

Apparently ...

... was not enough and an explicit comment is needed: InvocationStubber::willReturnOnConsecutiveCalls() is no longer deprecated.

[nicolas-grekas]

Thank you, I missed it indeed :)

[m-strzalka]

So it is no longer deprecated and will stay as a feature for the foreseeable future?