-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove instantiated (child process) objects from TestFailure #1352
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
60e949c
Added regression test for #1351.
sun 6529e40
Fix #1351: Isolated TestResult contains serialized test class upon fa…
sun 1aefe3a
Fixed PDOException::getCode() string vs. int mismatch.
sun abc60f8
Fixed bogus expectation in ExceptionStackTest.
sun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,128 @@ | ||
<?php | ||
/** | ||
* PHPUnit | ||
* | ||
* Copyright (c) 2001-2014, Sebastian Bergmann <sebastian@phpunit.de>. | ||
* All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions | ||
* are met: | ||
* | ||
* * Redistributions of source code must retain the above copyright | ||
* notice, this list of conditions and the following disclaimer. | ||
* | ||
* * Redistributions in binary form must reproduce the above copyright | ||
* notice, this list of conditions and the following disclaimer in | ||
* the documentation and/or other materials provided with the | ||
* distribution. | ||
* | ||
* * Neither the name of Sebastian Bergmann nor the names of his | ||
* contributors may be used to endorse or promote products derived | ||
* from this software without specific prior written permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS | ||
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE | ||
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, | ||
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
* POSSIBILITY OF SUCH DAMAGE. | ||
* | ||
* @package PHPUnit | ||
* @subpackage Framework | ||
* @author Sebastian Bergmann <sebastian@phpunit.de> | ||
* @copyright 2001-2014 Sebastian Bergmann <sebastian@phpunit.de> | ||
* @license http://www.opensource.org/licenses/BSD-3-Clause The BSD 3-Clause License | ||
* @link http://www.phpunit.de/ | ||
* @since File available since Release 4.1.5 | ||
*/ | ||
|
||
/** | ||
* Wraps Exceptions thrown by code under test. | ||
* | ||
* Re-instantiates Exceptions thrown by user-space code to retain their original | ||
* class names, properties, and stack traces (but without arguments). | ||
* | ||
* Unlike PHPUnit_Framework_Exception, the complete stack of previous Exceptions | ||
* is processed. | ||
* | ||
* @package PHPUnit | ||
* @subpackage Framework | ||
* @author Daniel F. Kudwien <sun@unleashedmind.com> | ||
* @copyright 2001-2014 Sebastian Bergmann <sebastian@phpunit.de> | ||
* @license http://www.opensource.org/licenses/BSD-3-Clause The BSD 3-Clause License | ||
* @link http://www.phpunit.de/ | ||
* @since Class available since Release 4.1.5 | ||
*/ | ||
class PHPUnit_Framework_ExceptionWrapper extends PHPUnit_Framework_Exception | ||
{ | ||
/** | ||
* @var string | ||
*/ | ||
protected $classname; | ||
|
||
/** | ||
* @var PHPUnit_Framework_ExceptionWrapper|null | ||
*/ | ||
protected $previous; | ||
|
||
public function __construct(Exception $e) | ||
{ | ||
// PDOException::getCode() is a string. | ||
// @see http://php.net/manual/en/class.pdoexception.php#95812 | ||
parent::__construct($e->getMessage(), (int) $e->getCode()); | ||
|
||
$this->classname = get_class($e); | ||
$this->file = $e->getFile(); | ||
$this->line = $e->getLine(); | ||
|
||
$this->serializableTrace = $e->getTrace(); | ||
foreach ($this->serializableTrace as $i => $call) { | ||
unset($this->serializableTrace[$i]['args']); | ||
} | ||
|
||
if ($e->getPrevious()) { | ||
$this->previous = new self($e->getPrevious()); | ||
} | ||
} | ||
|
||
/** | ||
* @return string | ||
*/ | ||
public function getClassname() | ||
{ | ||
return $this->classname; | ||
} | ||
|
||
/** | ||
* @return PHPUnit_Framework_ExceptionWrapper | ||
*/ | ||
public function getPreviousWrapped() | ||
{ | ||
return $this->previous; | ||
} | ||
|
||
/** | ||
* @return string | ||
*/ | ||
public function __toString() | ||
{ | ||
$string = PHPUnit_Framework_TestFailure::exceptionToString($this); | ||
|
||
if ($trace = PHPUnit_Util_Filter::getFilteredStacktrace($this)) { | ||
$string .= "\n" . $trace; | ||
} | ||
|
||
if ($this->previous) { | ||
$string .= "\nCaused by\n" . $this->previous; | ||
} | ||
|
||
return $string; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify: I'm aware that PHPUnit's current code contains almost no developer documentation at this point. I don't know whether that has been an informed decision or whether it's just caused by laziness.
However, in case of deeply internal PHP gems like this, it's guaranteed that every contributor who studies the code will have no idea why PHPUnit is doing what it's doing (unless she's familiar with the problem space already, which is very unlikely). Having to grep commit logs first, just because some code happens to resolve a complex problem space, presents a barrier to contribution. That's to be avoided.
Therefore, it's best to make it easy for new contributors to understand (at minimum) architecture-level considerations and pitfalls. Doing so is a qualified and verified approach to increase contributions.
(In fact, being deeply involved in one of the largest and most thriving FOSS communities, I won't hesitate to say that this is the key to sustainable success, specifically with regard to the quality and amount of user contributions.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lack of developer documentation likely stems from the fact that PHPUnit was developed and maintained by a single developer for most of its history. I find notes like this very helpful.