Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to #1351: Restore TestFailure::failedTest() #1359

Merged
merged 1 commit into from
Jul 27, 2014

Conversation

sun
Copy link
Contributor

@sun sun commented Jul 27, 2014

Resolves #1351: Follow-up to restore backwards-compatibility for test Result printer implementations that rely on TestFailure::failedTest().

Example: Codeception/Codeception#1248

Requires #1360 to identify whether the failing test operates in process isolation.

* @return boolean
* @since Method available since Release 4.1.5
*/
public function isInIsolation()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing this since we've already merged #1360?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

whatthejeff added a commit that referenced this pull request Jul 27, 2014
Follow-up to #1351: Restore TestFailure::failedTest()
@whatthejeff whatthejeff merged commit 8a68c88 into sebastianbergmann:master Jul 27, 2014
@whatthejeff
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process isolation TestResult contains serialized test class upon test failure/exception
2 participants