-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deprecation warning when called with just a class name #3860
add deprecation warning when called with just a class name #3860
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3860 +/- ##
============================================
+ Coverage 83.6% 83.62% +0.01%
- Complexity 3871 3875 +4
============================================
Files 151 151
Lines 10236 10241 +5
============================================
+ Hits 8558 8564 +6
+ Misses 1678 1677 -1
Continue to review full report at Codecov.
|
Hey @sebastianbergmann, |
@sebastianbergmann should i rebase this on |
This branch has conflicts that must be resolved. The target branch should be |
4a7d508
to
79e652b
Compare
79e652b
to
155dae3
Compare
I rebased on master and solved the conflict, everything green now 😄 |
@sebastianbergmann had you time reviewing this? |
@MaXal Using
Also note that we are not deprecating/removing the ability to invoke the PHPUnit test runner with the path to a test case class sourcecode file. We are "just" deprecating/removing the ability to invoke it with only a test case class name. |
@sebastianbergmann Thank you for the answer! We will update the line we're using to run tests. |
This adds the deprecation warning when calling PHPUnit with just a class name or class name and filename as discussed in issue #3859