Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove class name as CLI option #4013

Conversation

realFlowControl
Copy link
Contributor

This pull request removes the class name as CLI option as stated in #4012

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #4013 into master will decrease coverage by <.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4013      +/-   ##
============================================
- Coverage     85.52%   85.52%   -0.01%     
+ Complexity     3850     3826      -24     
============================================
  Files           156      157       +1     
  Lines          9716     9678      -38     
============================================
- Hits           8310     8277      -33     
+ Misses         1406     1401       -5
Impacted Files Coverage Δ Complexity Δ
src/TextUI/TestRunner.php 68.87% <ø> (-0.1%) 299 <0> (-1)
src/TextUI/Help.php 100% <ø> (ø) 25 <0> (ø) ⬇️
src/TextUI/Command.php 76.49% <100%> (+0.1%) 205 <0> (-13) ⬇️
src/Framework/Exception/ClassNotFoundException.php 100% <100%> (ø) 1 <1> (?)
src/Runner/BaseTestRunner.php 80.64% <100%> (+10.64%) 11 <9> (-1) ⬇️
src/Util/FileLoader.php 100% <100%> (ø) 8 <0> (ø) ⬇️
src/Runner/StandardTestSuiteLoader.php 85.18% <87.5%> (-6.12%) 16 <15> (-10)
src/Framework/MockObject/MockMethod.php 99.28% <0%> (ø) 47% <0%> (ø) ⬇️
src/Util/PHP/AbstractPhpProcess.php 72.78% <0%> (-2.73%) 43% <0%> (ø)
src/Util/Log/JUnit.php 96.55% <0%> (ø) 34% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bedd45...5ae37a4. Read the comment docs.

@sebastianbergmann sebastianbergmann added this to the PHPUnit 9.0 milestone Jan 12, 2020
@sebastianbergmann sebastianbergmann added type/backward-compatibility Something will be/is intentionally broken feature-removal labels Jan 12, 2020
@sebastianbergmann
Copy link
Owner

Looks good so far. Now we only need to remove the actual code :) Do you know when you will have time to finish this? Would be great to have to this ready by the end of next week. Thanks!

@realFlowControl
Copy link
Contributor Author

End of next week sound feasible as i was planing to invest more time this weekend

@realFlowControl
Copy link
Contributor Author

Hey @sebastianbergmann,

not yet finalized, but I will continue tomorrow.
One thing I like to notice: In the current state I removed the magic, that looked around in the included file to find some class that is not abstract and a subclass of \PHPUnit\Framework\TestCase if everything else fails. I could easily add this behavior again and was removing it because I think this should be part of this cleanup. Just ping me if you like to have that fallback added back again.

/Flo

@realFlowControl realFlowControl force-pushed the remove-class-name-as-cli-option branch from a17ed19 to 8fc6a83 Compare January 20, 2020 12:21
@realFlowControl realFlowControl marked this pull request as ready for review January 22, 2020 12:37
@realFlowControl realFlowControl force-pushed the remove-class-name-as-cli-option branch from 884be43 to 5ae37a4 Compare January 22, 2020 12:42
@realFlowControl
Copy link
Contributor Author

Rebased on master branch

@realFlowControl
Copy link
Contributor Author

I'll have a look at the code coverage report. That decreased with rebasing on master branch 😞

@sebastianbergmann sebastianbergmann merged commit 97db647 into sebastianbergmann:master Jan 23, 2020
@realFlowControl realFlowControl deleted the remove-class-name-as-cli-option branch February 13, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/backward-compatibility Something will be/is intentionally broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants