-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove class name as CLI option #4013
Remove class name as CLI option #4013
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4013 +/- ##
============================================
- Coverage 85.52% 85.52% -0.01%
+ Complexity 3850 3826 -24
============================================
Files 156 157 +1
Lines 9716 9678 -38
============================================
- Hits 8310 8277 -33
+ Misses 1406 1401 -5
Continue to review full report at Codecov.
|
Looks good so far. Now we only need to remove the actual code :) Do you know when you will have time to finish this? Would be great to have to this ready by the end of next week. Thanks! |
End of next week sound feasible as i was planing to invest more time this weekend |
Hey @sebastianbergmann, not yet finalized, but I will continue tomorrow. /Flo |
a17ed19
to
8fc6a83
Compare
884be43
to
5ae37a4
Compare
Rebased on |
I'll have a look at the code coverage report. That decreased with rebasing on |
This pull request removes the class name as CLI option as stated in #4012