Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of single line DocBlock #4693

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

ostrolucky
Copy link
Contributor

See #4692

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #4693 (91a7c02) into master (2b58853) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4693   +/-   ##
=========================================
  Coverage     83.94%   83.94%           
  Complexity     5416     5416           
=========================================
  Files           456      456           
  Lines         14288    14288           
=========================================
  Hits          11994    11994           
  Misses         2294     2294           
Impacted Files Coverage Δ
src/Metadata/Parser/Annotation/DocBlock.php 96.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b58853...91a7c02. Read the comment docs.

@ostrolucky
Copy link
Contributor Author

Test failures don't seem related

@sebastianbergmann
Copy link
Owner

Test failures don't seem related

No, they're not. See #4694.

@sebastianbergmann sebastianbergmann merged commit 31b50f0 into sebastianbergmann:master Jun 4, 2021
@sebastianbergmann
Copy link
Owner

Thanks!

@ostrolucky
Copy link
Contributor Author

Thx for merge. Please don't forget to backport to 8.5

@sebastianbergmann
Copy link
Owner

I backported this to PHPUnit 8.5 and PHPUnit 9.5 before I closed #4692.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants