New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`--log-events-text` and `--log-events-verbose-text` CLI options do not handle absolute and relative paths #5633

Merged

sebastianbergmann merged 4 commits into sebastianbergmann:10.5 from marac19901990:10.5-resolve-relative-path

Dec 31, 2023

Contributor

marac19901990 commented Dec 31, 2023

Resolve both relative and absolute paths, and handle invalid arguments.

marac19901990 mentioned this pull request

The path passed to --log-events-text or --log-events-verbose-text must be absolute #5608

Closed

marac19901990 changed the title ~~https://github.com/sebastianbergmann/phpunit/issues/5608 Resolve --log-events-text and --log-events-verbose-text argument both as relative and absolute~~ #5608 Resolve --log-events-text and --log-events-verbose-text argument both as relative and absolute

marac19901990 changed the base branch from main to 10.5

December 31, 2023 08:29

sebastianbergmann force-pushed the 10.5-resolve-relative-path branch from d8ed303 to a63b6ec Compare

December 31, 2023 08:31

sebastianbergmann added type/bug feature/test-runner feature/events labels

sebastianbergmann reviewed

View reviewed changes

tests/end-to-end/cli/log-events-verbose-text-invalid-argument.phpt Outdated Show resolved Hide resolved

sebastianbergmann reviewed

View reviewed changes

tests/end-to-end/cli/log-events-text-invalid-argument.phpt Outdated Show resolved Hide resolved

sebastianbergmann reviewed

View reviewed changes

tests/end-to-end/cli/log-events-text-invalid-argument.phpt Outdated Show resolved Hide resolved

sebastianbergmann reviewed

View reviewed changes

tests/end-to-end/cli/log-events-verbose-text-invalid-argument.phpt Outdated Show resolved Hide resolved

sebastianbergmann reviewed

View reviewed changes

src/TextUI/Configuration/Cli/Builder.php Outdated Show resolved Hide resolved

sebastianbergmann reviewed

View reviewed changes

src/TextUI/Configuration/Cli/Builder.php Outdated Show resolved Hide resolved

sebastianbergmann changed the title ~~#5608 Resolve --log-events-text and --log-events-verbose-text argument both as relative and absolute~~ --log-events-text and --log-events-verbose-text CLI options do not handle absolute and relative paths

sebastianbergmann removed the feature/events label

sebastianbergmann reviewed

View reviewed changes

tests/end-to-end/cli/log-events-text-invalid-argument.phpt Outdated Show resolved Hide resolved

sebastianbergmann reviewed

View reviewed changes

tests/end-to-end/cli/log-events-verbose-text-invalid-argument.phpt Outdated Show resolved Hide resolved

codecov bot commented Dec 31, 2023 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c61d971) 89.40% compared to head (1b248a3) 89.41%.

Additional details and impacted files

@@            Coverage Diff            @@
##               10.5    #5633   +/-   ##
=========================================
  Coverage     89.40%   89.41%           
- Complexity     6408     6410    +2     
=========================================
  Files           682      682           
  Lines         20383    20391    +8     
=========================================
+ Hits          18224    18232    +8     
  Misses         2159     2159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marac19901990 added 4 commits

December 31, 2023 17:08


          resolve both relative and absolute paths

2f9e89c


          fix portability issues

0d63a10


          improve formatting

a4f726a


          improve portability

1b248a3

sebastianbergmann force-pushed the 10.5-resolve-relative-path branch from 47e7b60 to 1b248a3 Compare

December 31, 2023 16:08

sebastianbergmann merged commit 719eb0c into sebastianbergmann:10.5

31 checks passed

marac19901990 deleted the 10.5-resolve-relative-path branch

December 31, 2023 16:24

Contributor

theofidry commented Jan 2, 2024

Thanks!

Owner

sebastianbergmann commented Jan 3, 2024 •

edited

Loading

I just noticed that this breaks --log-events-text php://stdout:

The path "php://stdout" specified for the --log-events-text option could not be resolved

Values given for --log-events-text and --log-events-verbose-text that begin with 'php://' or socket:// need to be excluded from this check, I assume.

@marac19901990 Can you please have a look at this? Thanks!

Owner

sebastianbergmann commented Jan 3, 2024

@marac19901990 Nevermind, I think I have a patch ready.

mfn mentioned this pull request

--log-events-text and --log-events-verbose-text require the destination file to exit #5692

Closed

sebastianbergmann added a commit that referenced this pull request


          Closes #5692 (which was a regression introduced with the fix for #5633)

93b9806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/test-runner type/bug