Prevent file IO when not strictly necessary

[staabm]

file IO largely depends on hardware and performance can vary a lot. it needs to be avoided at all cost.
especially on windows IO is slow (in comparison to linux based systems).

this PR re-orders conditions to do the IO only at the very last.

[codecov]

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 90.08%. Comparing base (81bcbcd) to head (6494815).

Files	Patch %	Lines
src/Runner/PhptTestCase.php	0.00%	5 Missing ⚠️
src/Util/PHP/AbstractPhpProcess.php	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               10.5    #5742      +/-   ##
============================================
- Coverage     90.08%   90.08%   -0.01%     
+ Complexity     6438     6436       -2     
============================================
  Files           680      680              
  Lines         19534    19532       -2     
============================================
- Hits          17598    17596       -2     
  Misses         1936     1936              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[staabm]

should be good to go.

[Yurunsoft]

If I use set_error_handler() in my program to catch errors and turn warnings into exceptions, this PR will make it impossible to test.

Message:  file_get_contents(/imi/tests/.phpunit.result.cache): Failed to open stream: No such file or directory
Location: /imi/vendor/phpunit/phpunit/src/Runner/ResultCache/DefaultResultCache.php:88

https://github.com/imiphp/imi/actions/runs/8342624739/job/22831196788

[staabm]

Sounds like your error handler does not properly detect the @ suppression.

Could you provide more information and a full reproducer (please open a new issue)

[sebastianbergmann]

@staabm This was now reported again as #5764. While I do think that this caused by custom error handlers that are too eager and/or interfere with PHPUnit's error handler, I am leaning towards (partially) reverting these changes.

[staabm]

@sebastianbergmann let me try to clean this up a bit, so we are more generous in such cases

[Yurunsoft]

This PR fixes my issue: imiphp/imi#683

Use 0 === (error_reporting() & $errno) in set_error_handler

[staabm]

@Yurunsoft your PR looks good.

The latest phpunit release relaxed this PRs changes/regressions with #5765