Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Mocking closures is doable today by mocking
__invoke
on an invokable class. However, this is troublesome, as it requires writing an invokable class and mocking a class method (which is confusing, hard to figure out, and makes tests harder to understand afterward).Here is another approach that is verbose and fragile:
The solution
This new helper makes things easier via a new
$this->createClosureMock()
method.Here's the test above rewritten using the new helper:
This is essentially just a shortcut to the workaround that is doable today, so this PR should not introduce too much new code.
Related to #3536
Note that #3536 mentioned a workaround using
stdClass
. I was not able to make it work: PHPUnit refused to mock stdClass's__invoke
method because it does not exist.This is, to me, yet another reason to have such a helper.