Replace deprecated dash-functional dependency #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress for this? |
|
Ping. |
PythonNut
added a commit
to PythonNut/quark-emacs
that referenced
this pull request
Jun 30, 2021
PythonNut
added a commit
to PythonNut/quark-emacs
that referenced
this pull request
Jun 30, 2021
|
It looks like #168 tried to address this, but that solution is incomplete. |
@sebastiencs I've updated this PR so that together with PR #170 it fixes the dependency issues. Thanks. |
|
Ping. |
|
@basil-conto Thanks ! |
iris-garcia
pushed a commit
to iris-garcia/company-box
that referenced
this pull request
Oct 25, 2021
Dash 2.18.0 subsumed dash-functional, and company-box no longer loads dash-functional, but it still lists old versions of dash and dash-functional as dependencies, which can cause issues. While at it, require the latest version 2.19.0 of Dash. Re: sebastiencs#152, sebastiencs#153, sebastiencs#156, sebastiencs#157, sebastiencs#161, sebastiencs#168, sebastiencs#170.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dash 2.18.0 now subsumes
dash-functional.See https://github.com/magnars/dash.el/blob/master/NEWS.md#from-217-to-218