Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove import assertions feature #377

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Remove import assertions feature #377

merged 1 commit into from
Feb 22, 2023

Conversation

adams85
Copy link
Collaborator

@adams85 adams85 commented Feb 19, 2023 •
edited
Loading

As the import assertions feature has been demoted from Stage 3 to Stage 2 and the syntax may change in the future, I propose to remove this feature until finalized.

If the syntax won't change, we'll be able to put the feature back pretty easily by reverting these changes.

Please let me know if you disagree. If you think that this feature should be still included, I'm ok with that.

@adams85 adams85 requested a review from lahma February 19, 2023 18:43
lahma
lahma approved these changes Feb 19, 2023
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, shame to remove for the time being, but wise.

@lahma
Copy link
Collaborator

lahma commented Feb 22, 2023

@adams85 is this the bits that would be blocking releasing RC1, or maybe something more?

@adams85
Copy link
Collaborator Author

adams85 commented Feb 22, 2023 •
edited
Loading

Nope. Sorry, I forgot to merge this.

I have no further BCs to the public API in mind and AFAICS there are no issues/PRs which would need a BC either. So, it looks we're good for a rc1!

@adams85 adams85 merged commit 695825c into main Feb 22, 2023
@adams85 adams85 deleted the proposal/remove-import-assertions branch February 22, 2023 20:34
adams85 added a commit that referenced this pull request Apr 9, 2023
@adams85
Revert "Remove import assertions feature (#377)"
e3e8bd0 
This reverts commit 695825c.
@adams85 adams85 mentioned this pull request Apr 9, 2023
Merged
adams85 added a commit that referenced this pull request Jul 27, 2023
@adams85
Revert "Remove import assertions feature (#377)"
f6a8b93 
This reverts commit 695825c.
adams85 added a commit that referenced this pull request Jul 28, 2023
@adams85
Add import attributes feature (#381)
755bac3 
* Revert "Remove import assertions feature (#377)"

This reverts commit 695825c.

* Apply syntax ("with" keyword instead of "assert") and ESTree naming changes ("Attributes" properties instead of "Assertions")

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adams85 @lahma