Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Directory.Packages.props does not respect PrivateAssets property #645

Merged
merged 7 commits into from
Apr 23, 2024
Merged

fix: Directory.Packages.props does not respect PrivateAssets property #645

merged 7 commits into from
Apr 23, 2024

Conversation

kaqq
Copy link
Contributor

@kaqq kaqq commented Apr 23, 2024 •
edited
Loading

@kaqq kaqq mentioned this pull request Apr 23, 2024
Closed
@lahma
Copy link
Collaborator

lahma commented Apr 23, 2024

I would suggest moving them to be GlobalPackageReference so they will implicitly be private assets, also no need to reference them in projects either after that.

https://github.com/quartznet/quartznet/blob/72fce9c599e020f4db0b0c77d277f9971d947a6f/Directory.Packages.props#L69-L74

lahma
lahma approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sebastienros sebastienros merged commit bbb64b3 into sebastienros:main Apr 23, 2024
2 checks passed
@sebastienros
Copy link
Owner

Thanks @kaqq , I just published a new release with your fix.

@hishamco
Copy link
Collaborator

hishamco commented May 4, 2024

Ths build is failed!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaqq @lahma @sebastienros @hishamco