Add support bell char and decode null char (#94)

* support bell char and decode null char * add tests for new chars --------- Co-authored-by: Luke Murray <luke@xysense.com>
sebastienros · Apr 24, 2024 · f1586c8 · f1586c8
1 parent e945eb0
commit f1586c8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/src/Parlot/Character.cs b/src/Parlot/Character.cs
@@ -116,6 +116,8 @@ public static TextSpan DecodeString(TextSpan span)
                             case '\'': c = '\''; break;
                             case '"': c = '\"'; break;
                             case '\\': c = '\\'; break;
+                            case '0': c = '\0'; break;
+                            case 'a': c = '\a'; break;
                             case 'b': c = '\b'; break;
                             case 'f': c = '\f'; break;
                             case 'n': c = '\n'; break;

diff --git a/src/Parlot/Scanner.cs b/src/Parlot/Scanner.cs
@@ -384,6 +384,7 @@ private bool ReadQuotedString(char quoteChar, out TokenResult result)
                     {
                         case '0':
                         case '\\':
+                        case 'a':
                         case 'b':
                         case 'f':
                         case 'n':

diff --git a/test/Parlot.Tests/CharacterTests.cs b/test/Parlot.Tests/CharacterTests.cs
@@ -14,6 +14,8 @@ public class CharacterTests
         [InlineData(" \\xa0 ", " \xa0 ")]
         [InlineData(" \\xfh ", " \xfh ")]
         [InlineData(" \u03B2 ", " β ")]
+        [InlineData(" \\a ", " \a ")]
+        [InlineData(" \\0hello ", " \0hello ")]
 
         public void ShouldDescodeString(string text, string expected)
         {

diff --git a/test/Parlot.Tests/ScannerTests.cs b/test/Parlot.Tests/ScannerTests.cs
@@ -36,6 +36,7 @@ public void ShouldReadEscapedStringWithMatchingQuotes(string text, string expect
         [InlineData("\"Lo\\trem \\n ipsum\"", "\"Lo\\trem \\n ipsum\"")]
         [InlineData("'Lorem \\u1234 ipsum'", "'Lorem \\u1234 ipsum'")]
         [InlineData("'Lorem \\xabcd ipsum'", "'Lorem \\xabcd ipsum'")]
+        [InlineData("'\\a ding'", "'\\a ding'")]
         public void ShouldReadStringWithEscapes(string text, string expected)
         {
             Scanner s = new(text);