Update Parlot #36
Merged
Update Parlot #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
force-pushed
the
sebros/parlot
branch
from
7924662 to
17bad57
Compare
|
This is using Parlot 1.0.2 but the other libraries should not need to be updated as there are no breaking changes. Pinning OC to 1.0.2 would work too. |
MikeAlhayek
reviewed
Jul 23, 2024
| @@ -128,16 +128,17 @@ private Shortcode ParseShortcode() | |||
| { | |||
| arguments ??= CreateArgumentsDictionary(); | |||
|
|
|||
| arguments[argumentIndex.ToString()] = Character.DecodeString(new TextSpan(_scanner.Buffer, _result.Start + 1, _result.Length - 2)).ToString(); | |||
| arguments[argumentIndex.ToString()] = Character.DecodeString(_result)[1..^1].ToString(); | |||
lahma
reviewed
Jul 23, 2024
| <PackageReference Include="xunit" Version="2.4.0" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.4.0" /> | ||
| <PackageReference Include="coverlet.collector" Version="1.2.0" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0-release-24352-06" /> |
There was a problem hiding this comment.
NuGet package manager did it by itself, had not checked
There was a problem hiding this comment.
I had the pre-release checkbox
sebastienros
force-pushed
the
sebros/parlot
branch
from
17bad57 to
020cf9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.