Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alter column issue in Postgres #486

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

hishamco
Copy link
Contributor

@hishamco hishamco commented Apr 7, 2023

Fixes #483

@hishamco
Copy link
Contributor Author

hishamco commented Apr 7, 2023

While I'm working on this I found two issues:

1- modify is incorrect as discussed on the related issue
2- Also, we miss Type when we change the column datatype, seems no one alter the column previously in Postgres :)

One more thing that confused me, I'm expecting to not specify the type during the alteration, if we don't the default bytea is added to the column which is wrong

@hishamco
Copy link
Contributor Author

hishamco commented Apr 7, 2023

Nah, SQLite test is failed!! I presume because it doesn't support alteration if I'm not wrong, @sebastienros shall we move the test to PostgresTests?

@MikeKry
Copy link

MikeKry commented Apr 2, 2024

@hishamco

I would also expect that it is failing because sqlite does not support alter column..

Can this be merged? It is vital to have possibility to change column size in postgres.

@hishamco
Copy link
Contributor Author

hishamco commented Apr 2, 2024

@sebastienros could you please reply on my comment so we can finalize this PR?

@sebastienros
Copy link
Owner

Add [Skip] in the Sqlite tests then. There are some tests already that are ignored by db.

@hishamco
Copy link
Contributor Author

hishamco commented Apr 3, 2024

Ready to merge Seb

@sebastienros sebastienros merged commit f686141 into sebastienros:main Apr 4, 2024
1 check passed
@hishamco hishamco deleted the alter-postgres branch April 4, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'modify' keyword is not supported in postgres
3 participants