Removing unused BatchCommand.DefaultBuilderCapacity #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyzx86
reviewed
Aug 20, 2024
| @@ -9,8 +9,6 @@ namespace YesSql.Commands | |||
| { | |||
| public class BatchCommand : IIndexCommand | |||
| { | |||
| public static int DefaultBuilderCapacity = 10 * 1024; | |||
There was a problem hiding this comment.
This is a static attribute that allows developers to modify it, to adapt the maximum number of parameters for different databases
There was a problem hiding this comment.
The issue is that this property is never used in any concrete way. It's possible that at some point I actually used a StringBuilder, but this is not the case anymore and the current implementation (string.Concat) is actually better than StringBuilder. So this should be removed. This is a breaking change though and maybe it should be made obsolete instead.
There was a problem hiding this comment.
Obsoleted it instead.
sebastienros
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572.