-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to web-sys instead of stdweb. #241
Conversation
I've given it a few tries and had commented on it on discord, so I'm repeating them here for completeness. On web it works mostly fine but I found some issues:
Running on native Windows results in an assertion failure panic in |
@sebcrozet You mentioned on discord that "glow does not have functions like is_shader, is_program etc.", can you open an issue on the |
Thank you for your feedbacks @alvinhochun.
I opened a glow issue about the missing
If I remember correctly this was fixed in earlier versions of Kiss3d by validating that the shaders/programs being dropped are valid using the
Looks like something that should be configured in the
Weird, will have to investigate this.
This may be an assertion that did not exist before. |
Oh, for some reason I thought the past stdweb version called
Actually not a regression. The stdweb version also panics. Looks like it is caused by the camera code calling |
#242 should fix these issues. |
- Fix glow API changes - Added a few `verify!` calls - Move `Window::canvas` field to the end so that the GlWindow will not be dropped before other structs that requires the OpenGL Context in their `Drop` impl.
(web-sys) Update to glow 0.6
@sebcrozet I suppose the only remaining blocker is this? |
(web-sys) Add cleanup of listeners when Kiss3d ends
Fixed the CI. Let's merge this! thanks @alvinhochun for the additional fixes 💯 |
It appears that stdweb is mostly dead so I would like to switch to web-sys/wasm-bindgen instead. This is a breaking change because: